Yes, many good things came from it, but many bad things did, as well.
Here's what Rockefeller had to say in 1932:
"When Prohibition was introduced, I hoped that it would be widely supported by public opinion and the day would soon come when the evil effects of alcohol would be recognized. I have slowly and reluctantly come to believe that this has not been the result. Instead, drinking has generally increased; the speakeasy has replaced the saloon; a vast army of lawbreakers has appeared; many of our best citizens have openly ignored Prohibition; respect for the law has been greatly lessened; and crime has increased to a level never seen before."
I grew up with an alcoholic parent. In retrospect, I realize that being the principle breadwinner as well as trying to take care of an infant child and his sick, disabled wife pushed my father (back) to alcohol. I doubt that making it illegal would have helped much. If that had stopped him from drinking, he'd either have found something else to dull his mind from our rather unfortunate situation, or he'd probably have offed himself.
Mind, when I was in high school I was a violent prohibitionist. I hated everything to do with alcohol and more or less anyone who chose to enjoy it. My views on the subject have moderated since then, although I'm still committed to never drinking myself.
As for illegal drugs...well. I believe in full legalization of marijuana accompanied by marijuana-related crimes (driving under the influence, etc) and an age limit (probably 18, 12 if w/ a parent and in private). Age limits just beg to be broken, but they also open avenues to lighter, more appropriate punishments for minors who are just being kids.
